[xmlsec] Big patch to xmlsec in recent OpenOffice.org sources

Andrew Fan Xuelei.Fan at Sun.COM
Tue Mar 8 02:24:01 PST 2005


Aleksey Sanin wrote:

>>> Unfortunately, I found quite  a lot of problems with these changes:
>>>   - hmac does not work at all (I guess, the reason is symkeys.c 
>>> changes)
>>>   - aes key wrap does not at all
>>>   - many des encryption regression tests do not work
>>>
>> :-( But all of the above interfaces have been tested and used in 
>> encryption at staroffice internally. I'm afraid it is because we 
>> haven't change the app* implementations.
>
>
> Well, I don't know details about the testing you did. But I already
> found that none of AES encryption can possibly work because of line 112
> in symkeys.c which looks defenetly wrong to me :)
>
> #ifndef XMLSEC_NO_AES
>     if(xmlSecKeyDataCheckId(data, xmlSecNssKeyDataDesId)) {
>         ctx->cipher = CKM_AES_KEY_GEN;
>     } else
> #endif  /* XMLSEC_NO_AES */
>
Definitely wrong. :-P

-Andrew



More information about the xmlsec mailing list