[xmlsec] Building for UWP in 1.2.31

Aleksey Sanin aleksey at aleksey.com
Thu Nov 12 11:18:49 PST 2020


Sven,

You are correct, I reverted this change:

https://github.com/lsh123/xmlsec/commit/21bbcb04b62352331a15a0b8463ebb27a9b858bc

Sorry again about it -- as I said I can't recall why it
was changed in the first place.

Best,

Aleksey

On 11/11/20 1:07 AM, Sven Paschukat wrote:
> Hi Aleksey,
> 
> Following the winapifamily.h description there is another value WINAPI_FAMILY_PC_APP the WINAPI_FAMILY define could be set to. But I don't know UWP design enough in order to assess this.
> 
> But the code in my original PR was a direct copy from other projects, so I'm pretty sure the code
> #if !defined(WINAPI_FAMILY) || WINAPI_FAMILY == WINAPI_FAMILY_DESKTOP_APP
> should work as expected.
> 
> Regards,
> 
> Sven
> 
>> -----Urspr√ľngliche Nachricht-----
>> Von: Aleksey Sanin <aleksey at aleksey.com>
>> Gesendet: Dienstag, 10. November 2020 19:12
>> An: Sven Paschukat <Sven.Paschukat at starfinanz.de>; xmlsec at aleksey.com
>> Betreff: Re: [xmlsec] Building for UWP in 1.2.31
>>
>> Hi Sven,
>>
>> I have to admit that I don't remember why I've changed this condition from
>> your original pull request. I suspect it caused issues on Windows build. I
>> wonder if we should change it to this:
>>
>> #if !defined(WINAPI_FAMILY) || WINAPI_FAMILY !=
>> WINAPI_FAMILY_PHONE_APP
>>
>> Best,
>>
>> Aleksey
>>
>> On 11/10/20 3:55 AM, Sven Paschukat wrote:
>>> Hi Aleksey,
>>> In Commit
>>>
>> _https://github.com/lsh123/xmlsec/commit/2d3998090f8882c3aea41ed7705
>> 09
>>> 61813ba3beb_
>>>
>> <https://github.com/lsh123/xmlsec/commit/2d3998090f8882c3aea41ed7705
>> 09
>>> 61813ba3beb> you changed the (not) UWP condition to #if
>>> !defined(WINAPI_FAMILY) || (WINAPI_FAMILY !=
>>> WINAPI_FAMILY_DESKTOP_APP) Are you sure that's correct? To my
>>> understanding the WINAPI_FAMILY is set to WINAPI_FAMILY_PHONE_APP
>> on
>>> UWP, so building for UWP would direct the compiler to LoadLibraryA,
>>> which is not accessible then. The previous code #if
>>> !defined(WINAPI_FAMILY) || WINAPI_FAMILY ==
>> WINAPI_FAMILY_DESKTOP_APP
>>> looks better for me.
>>> Regards,
>>> Sven
>>>
>>> _______________________________________________
>>> xmlsec mailing list
>>> xmlsec at aleksey.com
>>> http://www.aleksey.com/mailman/listinfo/xmlsec
>>>


More information about the xmlsec mailing list