[webmasters] Re: [xmlsec] Big patch to xmlsec in
recent OpenOffice.org sources
aleksey at aleksey.com
Sun Feb 27 17:08:41 PST 2005
Hi, Channdler, Andrew!
I started reviewing the changes for xmlsec-mscrypto library and I
have few questions about your patch:
0) After applying the patch, I have quite a lot of failures in
xmlsec regression test suite. I wonder if you run the tests and know
the reasons for these failures?
1) xmlsec/include/xmlsec/mscrypto/akmngr.c, xmlsec/src/mscrypto/akmngr.c
Why do you need "AppliedKeyManager"? How is it different from the
"DefaultKeyManager" and do you think it would be easier to just
merge the two?
I understand that you are using refcounting for HCRYPTKEY and
HCRYPTPROV instead of system "duplicate" functionality to support
NT 4.0. However, it seems a little bit dangerouse to me to re-use
the same key handler from multiple threads. Do you know if MS
documentation says anything about this? Did you do any tests in
You commented out the code to get public key from a verified certificate
and replaced it with code that gets either public or private key.
I am not sure I understand why would you need a private key for
a "verify cert" operation. It seems impossible to me.
Chandler Peng wrote:
> Aleksey Sanin wrote:
>> Thanks, Chandler and Andrew!
>> I'l review these files during next week. But will you mind to re-send
>> them to xmlsec at aleksey.com mailing list, please? There are more folks
>> who can help me with review.
> OK , no problem :-)
>> Chandler Peng wrote:
>>> Andrew ,
>>> I have created a new diff file with "diff -uN" on xmlsec_1.2.6. This
>>> diff file only include the difference on the source and the related
>>> makefile . Our new source file need add to xmlsec is in the xmlsec.zip .
>>> Chandler Peng..
More information about the xmlsec