[xmlsec] exc c14n w/o comments bug

Aleksey Sanin aleksey at aleksey.com
Wed May 12 23:33:32 PDT 2004

 > I'm signing in a test.xml file this :

Thanks! Now I see the problem too. I have a libxml2 patch that fixes the
issue (see attached file). And it does not cause any regressions in
either LibXML2 or XMLSec. However, I would appreciate if you can try
it out in your environment before I check it in. Meantime I'll meditate
on it for a while to make sure it is a right thing to do.

Thanks again for the example!

-------------- next part --------------
Index: c14n.c
RCS file: /cvs/gnome/gnome-xml/c14n.c,v
retrieving revision 1.21
diff -u -r1.21 c14n.c
--- c14n.c	20 Apr 2004 02:05:30 -0000	1.21
+++ c14n.c	13 May 2004 05:38:24 -0000
@@ -757,7 +757,7 @@
 	if((attr->ns != NULL) && xmlC14NIsVisible(ctx, attr, cur)) {
 	    already_rendered = xmlExcC14NVisibleNsStackFind(ctx->ns_rendered, attr->ns, ctx);
-	    xmlC14NVisibleNsStackAdd(ctx->ns_rendered, attr->ns, (xmlNodePtr)attr); 
+	    xmlC14NVisibleNsStackAdd(ctx->ns_rendered, attr->ns, cur); 
 	    if(!already_rendered && visible) {
 		xmlListInsert(list, attr->ns); 

More information about the xmlsec mailing list