[xmlsec] xmlsec-mscrypto code review

John Belmonte jvb at prairienet.org
Sat Sep 20 06:28:25 PDT 2003


Aleksey wrote:

> 1) You should trust nobody!

> 3) Formatting. Just for clarification, the formating is:
> 
> tab size=8;indentation=4;insert spaces=yes

> 4) malloc/free vs. xmlMalloc/xmlFree

> 6) XMLSEC_ERRORS_R_XMLSEC_FAILED vs. XMLSEC_ERRORS_R_CRYPTO_FAILED

> 7) "size=%d;error=%d" instead of "size %d, error: %d":
> It would be great if xmlsec-mscrypto can follow the error message 
> standard adopted in the other files of xmlsec library:
> <name1>=<value1>;<name2>=<value2>;...

This is more good stuff for the HACKING document.


-- 
http:// if   le.o  /




More information about the xmlsec mailing list