[xmlsec] mscrypto api support, initial (alpha) release
wsh at xs4all.nl
Tue Sep 2 01:07:23 PDT 2003
Thanks for creating the cvs branch. I've checked out the new branch, and
discovered there are a few glitches causing the software won't compile out
of the box. These will be fixed, together with adjusting the code style
and layout. I'd already noticed that I wasn't using the identing/layout
used throughout the xmlsec lib, but in my enthousiasm I didn't take notice
of that (until now :)
The documentation found inside the souces is not complete at all, and
cannot be regarded as anything usefull at this time. I didn't spend any
time to that so far.
Thanks for the remarks, I'll update the code a bit following those.
Updates will follow (hopefully shortly :)
PS If you want to know more about the company I work for, check this
website out: http://www.cordys.com.
> Hi, Wouter!
> First of all, I would like to say "thanks" to you and Cordys R&D BV for
> your work with others! This is really great and I think many people
> would join me
> in saying "Thanks a lot!"
> I have created a special branch in xmlsec CVS for MSCrypto work. As we
> discussed before, we would merge this branch to the trunk as soon as we
> feel that the code is ready. The branch name is "XMLSEC_MSCRYPTO_083103"
> and the branch start tag is "XMLSEC_MSCRYPTO_083103_START". You can
> check out the branch using following CVS command:
> cvs -z3 -d ':pserver:anonymous at anoncvs.gnome.org:/cvs/gnome' checkout -r
> XMLSEC_MSCRYPTO_083103 xmlsec
> As usual, there might be some delay before changes would be propagated to
> anonymous CVS.
> I did not do a full review and I just did a quick look. I hope to do a
> more in depth
> review in a couple weeks. However, I have spotted few problems I would
> like to
> resolve. All of these are minor things but they help to maintain the
> project :)
> 0) AUTHORS file. Please update ./AUTHORS file and include appropriate
> information about you and your company. If you give a URL to your
> Web site then I can publish it on xmlsec pages too.
> 1) End-of-line. The patch has DOS (\r\n) end of line and the rest of
> the code
> uses UNIX (\n) one. I would prefer to keep the consistent code style
> I have converted all your files to use UNIX eol. I am not sure that
> could be done about that on your side but if you can check your
> editor settings
> and if there is an "eol" mode and set it to Unix. If you would not
> find it then it's
> not a big problem because I have a script to convert DOS eol to UNIX
> 2) Indentation. Well, it's completely screwed up :) I have fixed it
> in a few files
> but it's just wrong in all other places. Again, I would like to have
> consistent source
> code style thus I would appreciate if you can change your editor
> to have 4 character tabs and fill tabs with spaces.
> 3) Code style. There are few other things that are dif
More information about the xmlsec