[xmlsec] x509vfy.c:xmlSecOpenSSLX509NamesCompare()

Roumen Petrov xmlsec at roumenpetrov.info
Thu Jul 3 01:24:24 PDT 2003


Hi Aleksey,

In general to compare values in two X509 names we should do more tasks, 
but at moment this is enough.

Could you add "const" to suppress warnings:
.../x509vfy.c:974: warning: passing arg 1 of 
`xmlSecOpenSSLX509_NAME_ENTRY_cmp' from incompatible pointer type
.../x509vfy.c:974: warning: passing arg 2 of 
`xmlSecOpenSSLX509_NAME_ENTRY_cmp' from incompatible pointer type

===========================
--- src/openssl/x509vfy.c.ORIG    2003-07-03 10:00:21.000000000 +0300
+++ src/openssl/x509vfy.c    2003-07-03 11:11:17.000000000 +0300
@@ -958,7 +958,7 @@
 static
 int xmlSecOpenSSLX509_NAME_cmp(const X509_NAME *a, const X509_NAME *b) {
     int i,ret;
-    X509_NAME_ENTRY *na,*nb;
+    const X509_NAME_ENTRY *na,*nb;
 
     xmlSecAssert2(a != NULL, -1);
     xmlSecAssert2(b != NULL, 1);
===========================


Aleksey Sanin wrote:

> Yes :) Very close :) To simplify the code I've also changed
> [SNIP]






More information about the xmlsec mailing list